From 1fd6480cd22fa09de7e8c58d2cc9dec5de9e1338 Mon Sep 17 00:00:00 2001
From: Robin Krahnen <robin.krahnen@inwebs.com>
Date: Wed, 20 Apr 2022 17:36:29 +0200
Subject: [PATCH] revised code

---
 Tests/Functional/SettingsValidatorTest.php | 22 +++++++++++-----------
 composer.json                              |  3 +++
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/Tests/Functional/SettingsValidatorTest.php b/Tests/Functional/SettingsValidatorTest.php
index fa8317d..4f07567 100644
--- a/Tests/Functional/SettingsValidatorTest.php
+++ b/Tests/Functional/SettingsValidatorTest.php
@@ -22,9 +22,9 @@ class SettingsValidatorTest extends FunctionalTestCase
     {
         $result = $this->objectManager->get(SettingsValidator::class)->validate(new TestObject());
 
-        $this->assertTrue($result->hasErrors());
-        $this->assertCount(1, $result->getFlattenedErrors());
-        $this->assertCount(1, $result->forProperty('shouldBeFalse')->getErrors());
+        self::assertTrue($result->hasErrors());
+        self::assertCount(1, $result->getFlattenedErrors());
+        self::assertCount(1, $result->forProperty('shouldBeFalse')->getErrors());
     }
 
     /**
@@ -40,8 +40,8 @@ class SettingsValidatorTest extends FunctionalTestCase
             ->getBaseValidatorConjunction(TestObject::class)
             ->validate(new TestObject());
 
-        $this->assertTrue($result->hasErrors());
-        $this->assertCount(1, $result->getFlattenedErrors());
+        self::assertTrue($result->hasErrors());
+        self::assertCount(1, $result->getFlattenedErrors());
     }
 
     /**
@@ -54,9 +54,9 @@ class SettingsValidatorTest extends FunctionalTestCase
             ->get(SettingsValidator::class, ['validationGroups' => ['Default']])
             ->validate(new TestValidationGroupsDefaultObject());
 
-        $this->assertTrue($result->hasErrors(), 'No errors for validation group "Default"');
-        $this->assertCount(1, $result->getFlattenedErrors(), 'Got a non expected number of errors for group "Default"');
-        $this->assertCount(1, $result->forProperty('shouldBeTrue')->getErrors(), 'Got no error for property');
+        self::assertTrue($result->hasErrors(), 'No errors for validation group "Default"');
+        self::assertCount(1, $result->getFlattenedErrors(), 'Got a non expected number of errors for group "Default"');
+        self::assertCount(1, $result->forProperty('shouldBeTrue')->getErrors(), 'Got no error for property');
     }
 
     /**
@@ -69,8 +69,8 @@ class SettingsValidatorTest extends FunctionalTestCase
             ->get(SettingsValidator::class, ['validationGroups' => ['Custom']])
             ->validate(new TestValidationGroupsCustomObject());
 
-        $this->assertTrue($result->hasErrors(), 'No errors for validation group "Custom"');
-        $this->assertCount(1, $result->getFlattenedErrors(), 'Got a non expected number of errors for group "Custom"');
-        $this->assertCount(1, $result->forProperty('shouldBeFalse')->getErrors(), 'Got no error for property');
+        self::assertTrue($result->hasErrors(), 'No errors for validation group "Custom"');
+        self::assertCount(1, $result->getFlattenedErrors(), 'Got a non expected number of errors for group "Custom"');
+        self::assertCount(1, $result->forProperty('shouldBeFalse')->getErrors(), 'Got no error for property');
     }
 }
diff --git a/composer.json b/composer.json
index 4ccf900..e8379de 100644
--- a/composer.json
+++ b/composer.json
@@ -6,6 +6,9 @@
         "neos/flow": "^6.3.5",
         "php": ">=7.4"
     },
+    "require-dev": {
+        "phpunit/phpunit": "~8.5"
+    },
     "autoload": {
         "psr-4": {
             "DigiComp\\SettingValidator\\": "Classes/"