From d2e164d5e5a4e2a4bfb640a5afd5e01993a12de8 Mon Sep 17 00:00:00 2001 From: Ferdinand Kuhl Date: Tue, 14 Feb 2023 12:24:55 +0100 Subject: [PATCH] fix possible bug in restoring the original severity if ignoring parent errors --- src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php b/src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php index bb0eeda..ccbb3f9 100644 --- a/src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php +++ b/src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php @@ -57,7 +57,7 @@ class VariableCommentSniff extends \PHP_CodeSniffer\Standards\Squiz\Sniffs\Comme $oldSeverity = $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] ?? null; $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = 0; parent::processMemberVar($phpcsFile, $stackPtr); - if ($oldSeverity) { + if ($oldSeverity !== null) { $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = $oldSeverity; } else { unset($phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity']);